Crate Hierarchies: Initial Proposal - #21
Open
cr7pt0gr4ph7 wants to merge 11 commits into
Open
Conversation
Added details on implementation changes for crate hierarchies, including new parent_id field and removal of uniqueness requirement on crates.name.
Corrected the spelling of 'determined' in the proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To summarize the main motivation of the proposal:
Thanks to @ronso0 to pointing me to the proposal process.
Related PRs, issues & discussion
Included here to get GitHub to recognize those links. See the markdown document for further information on the relationship of those to the current proposal:
TreeItem::getUrl/setUrl,TreeItemModel::kUrlRoleandSidebarModel::UrlRolemixxx#16835Implementation PRs
PRs that are steps towards implementing this proposal:
DbId::toVariantOrNull()method for working with nullable database IDs mixxx#16829TreeItemModel::index(TreeItem*)method overload mixxx#16831setChildIndexExpanded/isChildIndexExpandedmixxx#16833TreeItem::getUrl/setUrl,TreeItemModel::kUrlRoleandSidebarModel::UrlRolemixxx#16835