Skip to content

fix(OVH): remove accidental copy-paste leftover - #440

Merged
JoergAtGithub merged 1 commit into
mixxxdj:websitefrom
acolombier:chore/ovh-wrong-input
Jul 29, 2026
Merged

fix(OVH): remove accidental copy-paste leftover#440
JoergAtGithub merged 1 commit into
mixxxdj:websitefrom
acolombier:chore/ovh-wrong-input

Conversation

@acolombier

Copy link
Copy Markdown
Member

No description provided.

@JoergAtGithub

Copy link
Copy Markdown
Member

Can you please explain, why the production condition is wrong here? Isn't the PR case not in the or condition?

@acolombier

acolombier commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

The way ternary value works in GH CI is

<condition> && 'valueIfTrue' || 'valueIfFalse'

production is the valueIsTrue for the environment_name input value (which was accidentally copy pasted and missed by Copilot review). Technically, it still work because && 'production' basically ends up being interpreted as a noop such that

<condition> && true && 'valueIfTrue' || 'valueIfFalse'

So this is really just noise and misleading, but doesn't have any impact per se

@JoergAtGithub

Copy link
Copy Markdown
Member

Ok, lets merge it!

@JoergAtGithub
JoergAtGithub merged commit 190ce21 into mixxxdj:website Jul 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants