This repository was archived by the owner on May 8, 2020. It is now read-only.
Handle global context errors (i.e. with no callback id) #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those global errors arise from, for example, invalid JSON
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those global errors arise from, for example, invalid JSON supplied to evaluateHandle().
Current pyppeteer revision just waits forever when that happens, because error happens on CDP level, not on callback level.
While it is possible to recover from such situation, it's somewhat hard to know what command caused the error. This patch just aborts all in-flight callbacks - which works for me but may not be the optimal way to handle such errors.