Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stylish as default formatter instead of eslint-formatter-codeframe #379

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

mizdra
Copy link
Owner

@mizdra mizdra commented Sep 28, 2024

close: #373

  • I think it depends on the situation as to whether codeframe or stylish is better.
    • codeframe is excellent for displaying the details of a problem. However, the output is too large, so it is not easy to see at a glance.
    • stylish has a small output, so it is easy to see at a glance. However, it is not possible to display problem details.
  • I was wondering which one to make the default, but I decided to make stylish the default for the following reasons.
    • codeframe is a 3rd-party package, and it is a little difficult to bundle it with eslint-interactive.
    • codeframe makes the package size of Peslint-interactive` larger.
    • If necessary, users can install eslint-formatter-codeframe themselves and use it as the formatter for eslint-interactive.

Screenshots

Before:
 2024-09-28 18 19 55

After:
 2024-09-28 18 18 58

@mizdra mizdra added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Sep 28, 2024
@mizdra mizdra changed the title Use default formatter instead of eslint-formatter-codeframe Use default formatter (stylish) instead of eslint-formatter-codeframe Sep 28, 2024
@mizdra mizdra changed the title Use default formatter (stylish) instead of eslint-formatter-codeframe Use default formatter as stylish instead of eslint-formatter-codeframe Sep 28, 2024
@mizdra mizdra changed the title Use default formatter as stylish instead of eslint-formatter-codeframe Use stylish as default formatter instead of eslint-formatter-codeframe Sep 28, 2024
@mizdra mizdra added Type: Feature New Feature and removed Type: Refactoring A code change that neither fixes a bug nor adds a feature labels Sep 28, 2024
 1:1 error Ban exponentiation operator ban-exponentiation-operator

<fixture>/src/import-order.js
 1:1 error Definition for rule 'import/order' was not found import/order
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the import plugin has not been loaded...

@mizdra mizdra marked this pull request as ready for review September 28, 2024 09:32
@mizdra mizdra merged commit f3575cf into main Sep 28, 2024
26 checks passed
@mizdra mizdra deleted the use-default-formatter branch September 28, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use default formatter instead of eslint-formatter-codeframe
1 participant