Remove quotes for CURRENT_PROJECT_VERSION value #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this Gem along with Fastlane. In one of the steps within my production lanes, I use fastlane's
bump_build_number
. Before bumping the version number, I usedpbxplorer
to override code signing settings – however, somehow I get this error when bumping the build number:After a lot of time digging around, fastlane 2.39.1 and above uses
agvtool
(i.e. Apple Generic Versioning Tool) to bump the build number. This led me to think that there's something fishy withagvtool
after pbxproj rewrite, so I tried manually checking viaagvtool what-version
, and it fails.Internally,
agvtool
looks forCURRENT_PROJECT_VERSION
– but after the rewrite, it becomes"CURRENT_PROJECT_VERSION"
. The added double-quotes are what's causing theagvtool
to fail. This PR fixes that by contextually checking and removing quotes fromCURRENT_PROJECT_VERSION
.I have been using this workaround for a few months now, without issues. Tests are all passing. Let me know what you think.