Multilingual ingest#1026
Open
Kxka wants to merge 2 commits into
Open
Conversation
Author
|
Commands to run: Create Update |
|
Tested this, and adds translations as expected. Please note that changes to islandora_workbench_integration is needed because Drupal still does not fully provide multilingual support via REST (https://www.drupal.org/docs/8/core/modules/rest/translations, https://www.drupal.org/project/rest_translation). The functionality basically checks if the incoming request is a patch and has a $language code, then adds a translation entry if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Github issue or other discussion
#259
mjordan/islandora_workbench_integration#40
What does this PR do?
Allows creating translation content/taxonomy terms from workbench
What changes were made?
Updated url logic to add langcode prefix to url for update and update_terms tasks, if langcode given in csv.
e.g. https://islandora.dev/it/islandora/manoscritti-letterari
How to test / verify this PR?
Changes for workbench integration here needs to be pulled. Or module from here needs to be added and enabled. Module is needed as Drupel currently does not have translation support for PATCHES using REST API.
Content language and translation needs to be enabled. Languages that are used (Chinese Traditional and Italian used in given sample csv) needs to be added.
Create content and taxonomy terms first, then use update to create translation content and update_terms to create translation taxonomy_terms (node_id and term_id needs to be manually changed for tests files). Include langcode in header and give langcode e.x. it (italian), zh-hant (Chinese Traditional).
Translated content/taxonomy terms should have same ID number as original with different translation language to verify creating translation stubs is working.
Interested Parties
@mjordan_
Checklist
setup.py?