Skip to content

Fixes #1036: create_terms task crashes on cardinality validation during --check #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devnull03 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #1036: create_terms task crashes on cardinality validation during --check #1037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions workbench_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7704,6 +7704,7 @@ def validate_csv_field_cardinality(config, field_definitions, csv_data):
field_cardinalities[field_name] == 1
and len(delimited_field_values) > 1
):
message = ""
if config["task"] == "create":
message = (
'CSV field "'
Expand All @@ -7712,14 +7713,30 @@ def validate_csv_field_cardinality(config, field_definitions, csv_data):
+ row[config["id_field"]]
+ " contains more values than the number "
)
if config["task"] == "update":
elif config["task"] == "update":
message = (
'CSV field "'
+ field_name
+ '" in record with node ID '
+ row["node_id"]
+ " contains more values than the number "
)
elif config["task"] == "create_terms":
message = (
'CSV field "'
+ field_name
+ '" in record with term name '
+ row["term_name"]
+ " contains more values than the number "
)
elif config["task"] == "update_terms":
message = (
'CSV field "'
+ field_name
+ '" in record with term ID '
+ row["term_id"]
+ " contains more values than the number "
)
message_2 = (
"allowed for that field ("
+ str(field_cardinalities[field_name])
Expand All @@ -7731,6 +7748,7 @@ def validate_csv_field_cardinality(config, field_definitions, csv_data):
int(field_cardinalities[field_name]) > 1
and len(delimited_field_values) > field_cardinalities[field_name]
):
message = ""
if config["task"] == "create":
message = (
'CSV field "'
Expand All @@ -7739,14 +7757,30 @@ def validate_csv_field_cardinality(config, field_definitions, csv_data):
+ row[config["id_field"]]
+ " contains more values than the number "
)
if config["task"] == "update":
elif config["task"] == "update":
message = (
'CSV field "'
+ field_name
+ '" in record with node ID '
+ row["node_id"]
+ " contains more values than the number "
)
elif config["task"] == "create_terms":
message = (
'CSV field "'
+ field_name
+ '" in record with term name '
+ row["term_name"]
+ " contains more values than the number "
)
elif config["task"] == "update_terms":
message = (
'CSV field "'
+ field_name
+ '" in record with term ID '
+ row["term_id"]
+ " contains more values than the number "
)
message_2 = (
"allowed for that field ("
+ str(field_cardinalities[field_name])
Expand Down