Add tests for checking of workbench_integration module version and add additional error handling/messaging in code#1066
Open
whikloj wants to merge 1 commit into
Open
Conversation
…d additional error handling/messaging in code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Github issue or other discussion
No issue, just a couple more tests and some additional error checking
What does this PR do?
Adds some unit tests of validating the islandora_workbench_integration version
What changes were made?
Tests added, also wrapped the
response.json()in atry exceptand capture some Exceptions.How to test / verify this PR?
This should not affect any existing behaviour
Interested Parties
@mjordan
Checklist
setup.py?