Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@

- name: Install dependencies
run: |
uv sync

Check warning on line 61 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--no-build" can lead to the execution of setup scripts. Make sure it is safe here.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfS&open=AZ_b9my-vvA5__4wKVfS&pullRequest=299

Check warning on line 61 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfT&open=AZ_b9my-vvA5__4wKVfT&pullRequest=299

- name: Check file formatting
uses: astral-sh/ruff-action@278981a28ce3188b1e39527901f38254bf3aac89 # v4.1.0
Expand Down Expand Up @@ -121,11 +121,11 @@
python-version: ${{ steps.python.outputs.python-path }}

- name: Install dependencies
run: uv sync

Check warning on line 124 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--no-build" can lead to the execution of setup scripts. Make sure it is safe here.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfU&open=AZ_b9my-vvA5__4wKVfU&pullRequest=299

Check warning on line 124 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfV&open=AZ_b9my-vvA5__4wKVfV&pullRequest=299

- name: Install additional backends
if: ${{ ! matrix.extras_best_effort && matrix.skip_extras == '' }}
run: uv sync --all-extras

Check warning on line 128 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--no-build" can lead to the execution of setup scripts. Make sure it is safe here.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfW&open=AZ_b9my-vvA5__4wKVfW&pullRequest=299

Check warning on line 128 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfX&open=AZ_b9my-vvA5__4wKVfX&pullRequest=299

# Work around actions/runner-images#7443 and install yq on windows runners
- name: Make yq tool available on Windows runners
Expand Down Expand Up @@ -159,7 +159,7 @@
fi
deps=("${extra_deps[@]:1}")
echo "::group::Installing $extra_name backend"
uv pip install "${deps[@]}" \

Check warning on line 162 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfY&open=AZ_b9my-vvA5__4wKVfY&pullRequest=299
|| IFS=' ' echo "::warning title=Could not install $extra_name solver backend::Failed to install ${deps[*]}"
echo "::endgroup::"
done <<< "$EXTRAS"
Expand All @@ -167,7 +167,7 @@
- name: Test with pytest
run: |
# codecov requires that the test results are shared in xunit1 / legacy format.
uv run pytest -v --junitxml=junit.xml -o junit_family=legacy
uv run pytest -v --junitxml=junit.xml -o junit_family=legacy --durations=10 --durations-min=1.0

Check warning on line 170 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfZ&open=AZ_b9my-vvA5__4wKVfZ&pullRequest=299
Comment thread
sonarqubecloud[bot] marked this conversation as resolved.
Dismissed

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
Expand Down Expand Up @@ -234,10 +234,10 @@
run: |
uv build
rm -f dist/.gitignore # get-releasenotes can't handle non-dist files here
echo "version=$(uvx uv-dynamic-versioning@"$UV_DYNAMIC_VERSIONING_VERSION")" >> "$GITHUB_OUTPUT"

Check warning on line 237 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--no-build" can lead to the execution of setup scripts. Make sure it is safe here.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfa&open=AZ_b9my-vvA5__4wKVfa&pullRequest=299

- name: Check build
run: uvx twine@"$TWINE_VERSION" check --strict dist/*

Check warning on line 240 in .github/workflows/ci-cd.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--no-build" can lead to the execution of setup scripts. Make sure it is safe here.

See more on https://sonarcloud.io/project/issues?id=mjpieters_rummikub-solver&issues=AZ_b9my-vvA5__4wKVfb&open=AZ_b9my-vvA5__4wKVfb&pullRequest=299

- name: Prepare Release Note
id: note
Expand Down
Loading