Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_by_headers returned wrong table when using nested tables #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sintemal
Copy link

find_by_headers would stop to early when scanning for headers, as it would treat headers of nested tables as headers of the top table

@sintemal
Copy link
Author

ping

@mk12
Copy link
Owner

mk12 commented Feb 7, 2023

Sorry, I'm not sure why I never saw this. Mentioning me (@mk12) might be more reliable.

I'm willing to merge this fix with two changes:

  • It should be possible to do it directly with CSS selectors. I think :scope > th instead of th would be sufficient. If that doesn't work, there's probably some way to refactor it to use tr > th.
  • It needs a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants