Skip to content

change to a proper config flow integration#724

Open
mikey0000 wants to merge 3 commits into
mkaiser:mainfrom
mikey0000:main
Open

change to a proper config flow integration#724
mikey0000 wants to merge 3 commits into
mkaiser:mainfrom
mikey0000:main

Conversation

@mikey0000

@mikey0000 mikey0000 commented May 7, 2026

Copy link
Copy Markdown

Sorry realized after the PR that modbus Manager basically does this, let me know if I should close this.

@Gnarfoz Gnarfoz requested a review from mkaiser May 7, 2026 12:08
@Gnarfoz

Gnarfoz commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Wow, that is... a giant pile of work! This was basically long-term goal #1 for years, and you just did the whole thing in one go? 😮

@mikey0000

Copy link
Copy Markdown
Author

Works pretty well and now handles bad registers, as I have an esp32 pretending to be a dtsu0666
Tested against my sh6.0RS

Well I had a bit of help 😉

@mkaiser

mkaiser commented May 7, 2026

Copy link
Copy Markdown
Owner

Wow!

Looks like a lot of work! Is there a migration path for the entity names, which can be automated ?

You mentioned that the user has to rename the entities. Is there a way to do this while installing?

(Sorry I am very inexperienced in terms of python and HA ...)

Maybe it is time to plan for the future as my yaml approach is a dead end. Would you want to create your own repository and I will link to it like for the modbus manager?

Is there a good way to test it without destroying history data?
I suppose it comes down to start with a modbus proxy and use two integrations in parallel.

@mikey0000

Copy link
Copy Markdown
Author

I'll run some tests, I can always create a migration to move them over without the user having to do anything

@TCzerny

TCzerny commented May 8, 2026

Copy link
Copy Markdown

Nice work... !!! Happy to test as well.

@TCzerny

TCzerny commented May 8, 2026

Copy link
Copy Markdown

Where do you like the testing results posted? Here or in your repo?
After a first quick test:

  • Adding a device took a bit of time but worked successfully.
  • Option Flow gives an error message after hitting OK button
  • Any ideas to "filter" unsupported entities e.g. my SH10RT has only 2 MPPTs

Will do a more detailed testing...

@mikey0000

Copy link
Copy Markdown
Author

Unsupported entities should not be added, it scans the registers for bad responses, but maintaining a list isn't hard either I do something similar in the mammotion integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants