change to a proper config flow integration#724
Conversation
|
Wow, that is... a giant pile of work! This was basically long-term goal #1 for years, and you just did the whole thing in one go? 😮 |
|
Works pretty well and now handles bad registers, as I have an esp32 pretending to be a dtsu0666 Well I had a bit of help 😉 |
|
Wow! Looks like a lot of work! Is there a migration path for the entity names, which can be automated ? You mentioned that the user has to rename the entities. Is there a way to do this while installing? (Sorry I am very inexperienced in terms of python and HA ...) Maybe it is time to plan for the future as my yaml approach is a dead end. Would you want to create your own repository and I will link to it like for the modbus manager? Is there a good way to test it without destroying history data? |
|
I'll run some tests, I can always create a migration to move them over without the user having to do anything |
|
Nice work... !!! Happy to test as well. |
|
Where do you like the testing results posted? Here or in your repo?
Will do a more detailed testing... |
|
Unsupported entities should not be added, it scans the registers for bad responses, but maintaining a list isn't hard either I do something similar in the mammotion integration |
Sorry realized after the PR that modbus Manager basically does this, let me know if I should close this.