Enable assertions for test builds and run sqlite tests #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default on Linux assertions are disabled
Owner
|
Interesting - thanks. I had not thought of this. I'm going to hold off releasing a new minor / patch version for a few days to see what else turns up or I can fix. |
Contributor
Author
|
Sorry for spamming with pull requests but this one does not make sense if sqlite tests were not accepted... P.S. const char * can not be fixed until python 3.13 :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1440.
Enable assertions (pass -UNDEBUG) and run SQLite tests so bugs like #1438 will not slip in accidentialy.
Test for empty connection string is added in c2770d4