Clean up compiler warnings on Windows builds#1477
Open
bkline wants to merge 1 commit into
Open
Conversation
Also provides the explanation of what's going on with the use of a dummy buffer address when binding parameters, as requested by a reviewer for another issue. Fixes mkleehammer#1476
bkline
force-pushed
the
1476-windows-warnings
branch
from
8908bd7 to
e7c42b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also provides the explanation of what's going on with the use of a dummy buffer address when binding parameters, as requested by a reviewer for another issue. I considered using a separate ticket and PR for that, but it sat in the middle of much of the work done for this ticket, and I didn't want to leave someone with an awkward merge to tackle.
Fixes #1476