Scan all TVP rows before binding#1481
Open
bkline wants to merge 1 commit into
Open
Conversation
bkline
force-pushed
the
996-tvp-decimals
branch
from
395a61f to
ab85815
Compare
This ensures that we bind with settings which will accomodate all of the values. Also fixed a bug which was looking in the wrong place for the ParameterType value when a TVP column value was None. Fixes mkleehammer#996
bkline
force-pushed
the
996-tvp-decimals
branch
from
ab85815 to
14fffd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that we bind with settings which will accomodate all of the values. Also fixed a bug which was looking in the wrong place for the ParameterType value when a TVP column value was None.
Fixes #996