Fix FunctionGemma parser for escaped braces and multiple calls - #1628
Open
ask-q-ai wants to merge 1 commit into
Open
Fix FunctionGemma parser for escaped braces and multiple calls#1628ask-q-ai wants to merge 1 commit into
ask-q-ai wants to merge 1 commit into
Conversation
zcbenz
requested changes
Aug 22, 2026
| ], | ||
| ) | ||
|
|
||
| def test_function_gemma_parses_ten_thousand_fixed_source_variants(self): |
Member
There was a problem hiding this comment.
This makes the test very slow, a single test case would be enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the string-aware balanced-brace approach used by the Gemma 4 parser to FunctionGemma.
This preserves braces, quotes, commas and multiline text inside
<escape>…<escape>arguments, supports hyphenated function names and multiple calls, and rejects incomplete calls clearly.Tests cover complete VisMan-like YAML, multiple calls, truncation, and 10,000 fixed-seed source variants.