Skip to content

Add Qwen3 and Qwen3-MoE #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Blaizzy
Copy link
Contributor

@Blaizzy Blaizzy commented Mar 21, 2025

No description provided.

@Blaizzy Blaizzy marked this pull request as draft March 21, 2025 16:44
@Blaizzy Blaizzy changed the title Add Qwen3 Add Qwen3 and Qwen3-MoE Mar 21, 2025
@awni
Copy link
Member

awni commented Mar 21, 2025

@Goekdeniz-Guelmez can you combine efforts with @Blaizzy here and merge in #42. The two PRs were back to back so let's make you both co-authors. But I think since this one came in first unless there is a good reason we can use it as the working draft.

@Blaizzy
Copy link
Contributor Author

Blaizzy commented Mar 21, 2025

Awesome, lets collaborate once again @Goekdeniz-Guelmez!

@Blaizzy
Copy link
Contributor Author

Blaizzy commented Mar 21, 2025

If you are interested you can check the @Goekdeniz-Guelmez moe.

still needs some work

@Goekdeniz-Guelmez
Copy link
Contributor

Wow, that was actually amazing timing :D, yes your PR should merge singer you was faster then me, I'll just look at your code here and give you some comments, and delete my PR.

@Goekdeniz-Guelmez
Copy link
Contributor

#44 Here is the draft PR, im now trying inference with it, I'll tell you how it goes.

@Blaizzy
Copy link
Contributor Author

Blaizzy commented Mar 21, 2025

Awesome!
Point your PR to my branch since it will depend on it.

@Blaizzy Blaizzy marked this pull request as ready for review March 24, 2025 13:20
@Blaizzy
Copy link
Contributor Author

Blaizzy commented Mar 24, 2025

Hey @awni

Fixed the bug on the MoE, unlike previous v2, the v3 now normalizes the experts topk probs.

We are ready to review, merge and wait for the official release!

@awni
Copy link
Member

awni commented Mar 24, 2025

Thanks!

@Blaizzy
Copy link
Contributor Author

Blaizzy commented Mar 24, 2025

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants