adding report-to-wandb #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goekdeniz-Guelmez
changed the title
|
@awni should be mergable now. |
|
It would be great having this integrated OOB 🙏 |
|
@awni should be mergeable now! |
angeloskath
requested changes
Apr 5, 2025
There was a problem hiding this comment.
Hey @Goekdeniz-Guelmez thanks for adding that!
I think it would be better to move this out of lora.py. I would do the following changes
- Add a file
mlx_lm/tuner/callbacks.py - Add
WandBCallbackthere- Use
try: import wandb; except: wandb = Nonepattern instead ofif - Initialize
wandbin the callback constructor - Accept the project name, config and optional wrapped callback in the callback constructor
- Use
- Change the
--report-to-wandbto--wandbor--wandb-projectand allow setting the project or the defaultNoneto disable the callback
- Updated WandB reporting mechanism to use a project name argument instead of a boolean flag. - Removed the old TrainingCallback class definition from trainer.py and imported it from callbacks. - Adjusted argument parsing to accommodate the new WandB configuration.
- Added log_dir parameter to WandBCallback constructor for specifying the logging directory. - Updated lora.py to pass adapter_path as log_dir when initializing WandBCallback.
|
Hey @angeloskath your suggestions are really helpful! I did what you said and it works as expected. Also the run config and data files are save in the |
|
You can now call it like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.