Open
Conversation
angeloskath
reviewed
Feb 17, 2026
Member
angeloskath
left a comment
There was a problem hiding this comment.
Looks good as well.
Feel free to fix the conflicts and then I can run the tests and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Blackman window function (
mlx.core.blackman), completing the standard trio of window functions (Hanning, Hamming, Blackman) and improving feature parity with NumPy.Implementation Details
mlx/ops.cpp.cosoperation followed by cheap polynomial arithmetic (M < 1(empty) andM = 1(returns[1.0]), matching NumPy's behavior exactly.nanobindwithnb::sigfor proper type hinting and full LaTeX documentation.Test Plan
Verified locally against NumPy for numerical accuracy and edge cases.
Verification script:
Unit Tests:
Added
test_blackmaninpython/tests/test_ops.py.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes