Allow async in client props #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
approved these changes
Oct 22, 2025
pedrobslisboa
added a commit
that referenced
this pull request
Oct 27, 2025
* origin/main: Specify model values at React (#309) feat: allow async in client props (#315) chore: add context to turn_element_into_payload revert: client_value to push revert: Fiber abstraction of render_element revert: remove push on async component revert: remove debug info changes chore: add better naming to root_data_payload feat: change serialize for to_chunk Improve CI (#313) feat: improve debugging due to new fiber/model contextg Add environtmnet for srr Client component's can't be functions refact: improve the Fiber and Model stream context fix: align Suspense with reason-react (#311) fix: adjust doc link on tests Fix broken link to browser_ppx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Client Components to have Async Components on their props.
It also get back with the
~pending:1on render_html that was wrongly removed from it at this PR. To avoid any new mistake like this I added a comment explaining why we need such a thing.