Skip to content

Conversation

@Jesse-Bakker
Copy link
Contributor

No description provided.

@Jesse-Bakker Jesse-Bakker force-pushed the tracing-opentelemetry-0-32 branch from ab51932 to cd516a3 Compare October 15, 2025 07:28
@Jesse-Bakker
Copy link
Contributor Author

Whoops, ran cargo check with the wrong feature set locally 🙈
The cargo-deny failure is unrelated

@mladedav
Copy link
Owner

I'll deal with the cargo deny failure.

Just so you know, I'm happy to merge this as is, but there are some issues with starting the context which might be helped by tokio-rs/tracing-opentelemetry#234 so I'm wondering if I want to wait for that or not (though it's waiting for me).

Do you need a release early?

@Jesse-Bakker
Copy link
Contributor Author

No need to rush a release from our side. We're currently on a fork for context activation because we rely on context access from SpanRef as well.

@halvorboe
Copy link

Is there anything blocking this? Would like to avoid forking the crate over this

@mladedav mladedav force-pushed the tracing-opentelemetry-0-32 branch from 1090df3 to 854173f Compare January 24, 2026 22:19
@mladedav mladedav merged commit 46b62d2 into mladedav:main Jan 24, 2026
11 checks passed
@github-actions github-actions bot mentioned this pull request Jan 24, 2026
@mladedav
Copy link
Owner

Sorry it took so long, it's ready now. I've just also bumped the patch version of tracing-opentelemetry as that should work better with the context activation I think.

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants