feat: add Llama 3.2 chat template with Cutting Knowledge Date - #3455
feat: add Llama 3.2 chat template with Cutting Knowledge Date#3455gururajkosuru wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new conversation template for Llama 3.2, along with corresponding unit tests. The implementation is generally good, but there is a significant issue with the Today Date being hardcoded in the template. This will cause the template to generate incorrect prompts for any conversation not occurring on that specific date. I've added comments highlighting this issue and suggesting a more robust, dynamic approach.
Add a new llama-3_2 conversation template that includes the
'Cutting Knowledge Date' and 'Today Date' preamble lines in the
system template, matching the official HuggingFace chat template.
The Today Date is populated dynamically at prompt generation time
using a new {today_date} placeholder in MessagePlaceholders, which
is replaced with the current date in as_prompt(). This ensures the
model always receives the correct current date.
Changes:
- Add TODAY_DATE to MessagePlaceholders enum
- Replace {today_date} placeholder in Conversation.as_prompt()
- Register llama-3_2 template using the new placeholder
- Add unit tests for the new template
Fixes mlc-ai#3002
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ab36d3a to
2af9962
Compare
Add a new llama-3_2 conversation template that includes the 'Cutting Knowledge Date' and 'Today Date' preamble lines in the system template, matching the official HuggingFace chat template.
Also adds unit tests for the new template verifying:
Fixes #3002