spec: expand radar precipitation scope to single-radar products#36
Merged
franchg merged 1 commit intoApr 23, 2026
Merged
Conversation
Previously the specification explicitly excluded single-radar datasets. The practical constraint is the 256x256 crop requirement within the valid sensing area (§3.2), which multi-radar composites and sufficiently-sized single-radar products can both satisfy (e.g. a single C-band radar at 1 km with ~480 px diameter, or finer resolution single-radar products). - §1 Introduction: "2D gridded radar ... datasets" instead of "composite datasets" - §2 Scope: explicitly include both multi-radar composites and single-radar products, subject to §3.2 - §3.2 Spatial Requirements: reword resolution clause to "2D gridded radar data"; clarify that the 256x256 sensing-area rule applies equally to composites and single-radar products
leifdenby
approved these changes
Apr 23, 2026
leifdenby
left a comment
Member
There was a problem hiding this comment.
Looks great to me - thanks for making these changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
[Unreleased] > Changedentry.Follow-ups (not in this PR)
check_spatial_requirementscurrently validates array dimensions, not the valid-data sensing disk. A single-radar product with heavy shadowing could pass by dims alone. Enforcing the disk-level requirement needs a mask/NaN convention that isn't yet in the spec — worth a separate discussion.standard_namevalues explicitly in the spec docs. Not included here.Test plan
uv run mkdocs build --strictproduces a clean spec render with the updated §1 / §2 / §3.2 text.