Skip to content

Conversation

@ccl-core
Copy link
Contributor

Loading lists from parquet using pandas deserializes them as numpy's ndarrays. However, we need lists as input to jsonpath_rw's find function (ndarrays return IndexError so we don't catch the exception in https://github.com/kennknowles/python-jsonpath-rw/blob/6f5647bb3ad2395c20f0191fef07a1df51c9fed8/jsonpath_rw/jsonpath.py#L436C1-L436C54)

@ccl-core ccl-core marked this pull request as ready for review November 12, 2024 09:47
@ccl-core ccl-core requested a review from a team as a code owner November 12, 2024 09:47
@github-actions
Copy link

github-actions bot commented Nov 12, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ccl-core ccl-core merged commit 068fccc into main Nov 12, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants