Skip to content

Preserve np.ndarray in field value casting #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Preserve np.ndarray in field value casting #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b15e359
Preserve native sample rate, don't auto-resample to 22050
tombagby Apr 15, 2025
871dafd
Merge branch 'mlcommons:main' into main
tombagby May 6, 2025
66a178c
Preserve np.ndarray in casting, do not cast to list.
tombagby May 8, 2025
1a9c09f
Merge branch 'mlcommons:main' into main
tombagby May 8, 2025
26be8bf
Don't change librosa in this branch
tombagby May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/mlcroissant/mlcroissant/_src/operation_graph/operations/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def _cast_value(ctx: Context, value: Any, data_type: type | term.URIRef | None):
return bounding_box.parse(value)
elif not isinstance(data_type, type):
raise ValueError(f"No special case for type {data_type}.")
elif isinstance(value, np.ndarray) and issubclass(data_type, np.generic):
return value.astype(data_type)
elif isinstance(value, list) or isinstance(value, np.ndarray):
return [_cast_value(ctx=ctx, value=v, data_type=data_type) for v in value]
elif data_type == bytes and not isinstance(value, bytes):
Expand Down
15 changes: 15 additions & 0 deletions python/mlcroissant/mlcroissant/_src/operation_graph/operations/field_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,21 @@ def test_cast_value(conforms_to, value, data_type, expected):
assert field._cast_value(ctx, value, data_type) == expected


@parametrize_conforms_to()
@pytest.mark.parametrize(
["value", "data_type", "expected"],
[
[np.array([1, 2, 3]), DataType.INTEGER, np.array([1, 2, 3])],
[np.array([1, 2, 3]), DataType.FLOAT32, np.array([1.0, 2.0, 3.0])],
],
)
def test_cast_value_ndarray():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

def test_cast_value_ndarray(conforms_to, value, data_type, expected):
  ...

ctx = Context(conforms_to=conforms_to)
cast_value = field._cast_value(ctx, value, data_type)
assert cast_value == expected
assert cast_value.dtype == expected.dtype


@parametrize_conforms_to()
@pytest.mark.parametrize(
["value", "data_type"],
Expand Down
Loading