Implement unArchive and readLines. #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidated containedIn handling to support all versions. - Added support for Source objects in containedIn. - Added unarchive and readlines to Transform. - Refactored containedIn logic into a helper function. - Added docstrings to magic methods in Source. - Fixed static analysis issues.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
benjelloun
approved these changes
Dec 1, 2025
| from mlcroissant._src.operation_graph.operations.read import Read | ||
| from mlcroissant._src.operation_graph.operations.read_lines import ReadLines | ||
|
|
||
| __all__ = [ |
Contributor
There was a problem hiding this comment.
Should this list be synced with the transformations/filters in the spec?
Contributor
Author
There was a problem hiding this comment.
I don't think so, some transformations are not implmeented as operations :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.