-
Notifications
You must be signed in to change notification settings - Fork 95
Add sdVersion property, and Data Use Conditions section to the 1.1 spec. #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benjelloun
merged 6 commits into
mlcommons:main
from
benjelloun:docs/update-spec-draft-v2
Dec 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
67b5931
Update croissant-spec-draft.md with edits from external contributors
benjelloun b8106d7
Merge branch 'mlcommons:main' into docs/update-spec-draft-v2
benjelloun c5ee8fe
Merge branch 'mlcommons:main' into docs/update-spec-draft-v2
benjelloun fcc20aa
Add sdVersion property to dataset metadata
benjelloun d4c8cdf
Add Data Use Conditions section
benjelloun 8cc47c4
Update ttl definition for Croissant 1.1. Minor spec clean-ups.
benjelloun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the usage of sc:DefinedTerm should not be recommended. It only covers part of the DUO terms and logic so its usage will be confusing for DUO adopters. On the other side, the ODRL approach fully covers DUO, and could scale to other data use conditions, such as those of Data Privacy Vocabulary, with the same mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It serves the purpose of how to use any simple term vocabulary in Croissant. I agree that for DUO you may most often need the ODRL approach, but this example is still useful for other vocabularies as well.