Added appropriate names for the GitHub actions #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sujik18
commented
Feb 6, 2025
sujik18
commented
- fix Better naming for github action runs #134
- build_wheel.yml -> updated enviornment parameter value
Fix mlcommons#165, Replacement in the initial three files
test name update
Update job key value and name parameter
on pull request,command to reflect the changes
reverted back to pull_request_target
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Feb 6, 2025
.github/workflows/build_wheel.yml
Outdated
| @@ -14,7 +14,9 @@ jobs: | |||
| if: github.repository_owner == 'mlcommons' | |||
| name: Build wheel | |||
| runs-on: ubuntu-latest | |||
| environment: release | |||
There was a problem hiding this comment.
We need this for pypi release. Any reason for this change?
There was a problem hiding this comment.
The environment field value was causing error,
Value 'release' is not valid
Available expression contexts: github, inputs, vars, needs, strategy, matrix
so i tried using env key to set environment variables
arjunsuresh
approved these changes
Feb 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.