Skip to content

Change logging levels based on verbose and silent #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
19b3563
change logging levels based on verbose and silent
mlcommons-bot Mar 10, 2025
9730957
changed env variable
anandhu-eng Mar 10, 2025
e155b22
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Mar 10, 2025
dea45e3
changes for logger
anandhu-eng Mar 11, 2025
bd5ebff
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Mar 11, 2025
4199dbe
Merge branch 'dev' into updateForLogging
arjunsuresh Mar 15, 2025
1834a08
Update meta.yaml
arjunsuresh Mar 15, 2025
fa42a26
Merge branch 'dev' into updateForLogging
arjunsuresh Mar 27, 2025
c53d138
Merge branch 'dev' into updateForLogging
arjunsuresh Mar 29, 2025
a8053f8
update logging level logic
anandhu-eng Mar 31, 2025
5fdbd5c
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Mar 31, 2025
96a6127
Merge branch 'dev' into updateForLogging
anandhu-eng Mar 31, 2025
ed3d96b
clean code
anandhu-eng Mar 31, 2025
2706838
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Mar 31, 2025
0eb6d97
code clean
anandhu-eng Mar 31, 2025
e6875e1
fix log levels for docker run
anandhu-eng Mar 31, 2025
5b140d5
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Mar 31, 2025
1f96146
clean code
anandhu-eng Mar 31, 2025
f2daf74
Merge branch 'updateForLogging' of https://github.com/anandhu-eng/mlp…
anandhu-eng Mar 31, 2025
f6e0c38
fix for log leveling inside docker
anandhu-eng Mar 31, 2025
1e39414
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Mar 31, 2025
51d8a6b
update docker.py
anandhu-eng Mar 31, 2025
8e7e008
Merge branch 'updateForLogging' of https://github.com/anandhu-eng/mlp…
anandhu-eng Mar 31, 2025
5aca801
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] Mar 31, 2025
6442264
update docker.py
anandhu-eng Mar 31, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions automation/script/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def dockerfile(self_module, input_params):
run_command_arc = prune_result['new_input']
current_directory = os.getcwd()
is_quiet_mode = input_params.get('quiet', False)
verbose = input_params.get('v', False)
is_console_output = input_params.get('out') == 'con'

# Step 2: Search for scripts
Expand Down Expand Up @@ -88,8 +87,7 @@ def dockerfile(self_module, input_params):
new_state_keys_from_meta=[], # Add state keys from meta if needed
add_deps_recursive=add_deps_recursive,
run_state=run_state,
recursion_spaces='',
verbose=verbose # Set to True or False as needed
recursion_spaces=''
)
if update_variations_result['return'] > 0:
return update_variations_result
Expand All @@ -109,7 +107,7 @@ def dockerfile(self_module, input_params):
deps = docker_settings.get('build_deps', [])
if deps:
r = self_module._run_deps(
deps, [], env, {}, {}, {}, {}, '', [], '', False, '', verbose,
deps, [], env, {}, {}, {}, {}, '', [], '', False, '',
show_time, ' ', run_state)
if r['return'] > 0:
return r
Expand Down Expand Up @@ -180,8 +178,34 @@ def dockerfile(self_module, input_params):
'comments': comments, 'run_cmd': f"{run_command_string} --quiet",
'script_tags': input_params.get('tags'), 'env': env,
'dockerfile_env': dockerfile_env,
'quiet': True, 'v': input_params.get('v', False), 'real_run': True
'quiet': True, 'real_run': True
}

docker_v = False
docker_s = False
if is_true(input_params.get(
'docker_v', input_params.get('docker_verbose', False))):
docker_v = True
if is_true(input_params.get(
'docker_s', input_params.get('docker_silent', False))):
docker_s = True

if docker_s and docker_v:
logger.warning(
"Both verbose and silent is set to True. Verbose will take precedence.")
docker_s = False

if not docker_s and not docker_v:
if logger.level == logging.DEBUG:
docker_v = True
elif logger.level == logging.WARNING:
docker_s = True

if docker_s:
mlc_docker_input['run_cmd'] += ' -s'
elif docker_v:
mlc_docker_input['run_cmd'] += ' -v'

mlc_docker_input.update(docker_inputs)

dockerfile_result = self_module.action_object.access(mlc_docker_input)
Expand Down Expand Up @@ -209,7 +233,6 @@ def docker_run(self_module, i):

# Extract and handle basic inputs
quiet = i.get('quiet', False)
verbose = i.get('v', False)
show_time = i.get('show_time', False)
logger = self_module.logger
env = i.get('env', {})
Expand Down Expand Up @@ -296,8 +319,7 @@ def docker_run(self_module, i):
posthook_deps=[],
new_env_keys_from_meta=[],
new_state_keys_from_meta=[],
add_deps_recursive=add_deps_recursive, run_state=run_state, recursion_spaces='',
verbose=False)
add_deps_recursive=add_deps_recursive, run_state=run_state, recursion_spaces='')
if r['return'] > 0:
return r

Expand All @@ -306,7 +328,7 @@ def docker_run(self_module, i):
deps = docker_settings.get('deps', [])
if deps:
r = self_module._run_deps(
deps, [], env, {}, {}, {}, {}, '', [], '', False, '', verbose,
deps, [], env, {}, {}, {}, {}, '', [], '', False, '',
show_time, ' ', run_state)
if r['return'] > 0:
return r
Expand Down Expand Up @@ -374,7 +396,7 @@ def docker_run(self_module, i):
'action': 'run', 'target': 'script', 'tags': 'run,docker,container',
'rebuild': rebuild_docker_image,
'env': env, 'mounts': mounts,
'script_tags': i.get('tags'), 'run_cmd': final_run_cmd, 'v': verbose,
'script_tags': i.get('tags'), 'run_cmd': final_run_cmd,
'quiet': True, 'real_run': True, 'add_deps_recursive': {'build-docker-image': {'dockerfile': dockerfile_path}},
**docker_inputs
}
Expand Down
5 changes: 4 additions & 1 deletion automation/script/docker_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,10 @@ def rebuild_flags(
command_line += f" --{full_key},={list_values}"
# Process scalar values.
else:
command_line += f" --{full_key}={quote}{str(value)}{quote}"
if full_key in ['s', 'v']:
command_line += f" -{full_key}"
else:
command_line += f" --{full_key}={quote}{str(value)}{quote}"

return command_line

Expand Down
Loading
Loading