Skip to content

Sync main with dev #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from
Closed

Sync main with dev #364

wants to merge 30 commits into from

Conversation

anandhu-eng
Copy link
Contributor

No description provided.

nathanw-mlc and others added 20 commits April 9, 2025 17:55
…359)

* Replace KSM with 1Password in test-mlperf-inference-tvm-resnet50.yml

* Add back if condition for secret fetching in test-mlperf-inference-tvm-resnet50.yml

* Replace KSM with 1Password in test-mlperf-inference-resnet50.yml

* Update op-load-secret to support Windows runner in test-mlperf-inference-resnet50.yml

* @nathanw-mlc Replace KSM with 1Password in test-mlperf-inference-rgat.yml

* Replace KSM with 1Password in test-mlperf-inference-retinanet.yml

* Add fetch-secret need in test-mlperf-inference-rgat.yml

* Add fetch-secret need in test-mlperf-inference-retinanet.yml

* Replace KSM with 1Password in test-mlc-script-features.yml

* Replace KSM with 1Password in test-mlperf-inference-mlcommons-cpp-resnet50.yml

* Simplify op-load-secret in test-mlc-script-features.yml

* Remove unnecessary checkout from op job in test-mlperf-inference-resnet50.yml

* Remove unnecessary checkout from op job in test-mlperf-inference-retinanet.yml

* Remove unnecessary checkout from op job in test-mlperf-inference-mlcommons-cpp-resnet50.yml

* Replace KSM with 1Password in test-mlperf-inference-resnet50-closed-division.yml

* Simplify 1Password implementation in test-mlperf-inference-rgat.yml

* Replace KSM with 1Password in test-mlperf-inference-bert-deepsparse-tf-onnxruntime-pytorch.yml
@anandhu-eng anandhu-eng requested a review from a team as a code owner April 16, 2025 18:25
Copy link
Contributor

github-actions bot commented Apr 16, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng
Copy link
Contributor Author

Hi @nathanw-mlc , Could you please check why fetch-secret fails? Also I see a sequence of characters in error message, is the secret key exposed?

@anandhu-eng anandhu-eng marked this pull request as draft April 16, 2025 18:43
@nathanw-mlc
Copy link
Member

Could you please check why fetch-secret fails?

Looking into it.

Also I see a sequence of characters in error message, is the secret key exposed?

That should be the encrypted secret, but just in case, could you send me an email with screenshots of what you're seeing so I can make sure nothing is exposed in plaintext?

@nathanw-mlc
Copy link
Member

Okay, I'm pretty sure I found the problem. base64 needs the -A option to ensure single line output; otherwise the output is too long and ends up being split into multiple lines, which GITHUB_OUTPUT does not support. I'll make a PR updating the fetch-secret job in the relevant workflows.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants