-
Notifications
You must be signed in to change notification settings - Fork 13
Auto GPU detection + Updated run args generation for 5.0 #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
anandhu-eng
wants to merge
22
commits into
mlcommons:dev
Choose a base branch
from
anandhu-eng:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 8 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4baae86
Update batch size to state
anandhu-eng 7cfca34
batch size - priority to state dict
anandhu-eng 06d81d6
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] 61e8eaa
update run command arguments for v5.0
anandhu-eng 24ff3a0
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] 618996a
extract nvidia gpu name automatically
anandhu-eng 537e647
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] 8b2ccfc
Update customize.py
anandhu-eng 796c363
update batch size extraction logic
anandhu-eng cdca719
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] 90ec0df
update packages
anandhu-eng c279990
add version for nvidia harness
anandhu-eng f707c9f
Update meta.yaml
anandhu-eng 07046e7
updated package version
anandhu-eng 79de08b
Merge branch 'dev' into dev
arjunsuresh ec27be0
modify batch size format based on inference version
anandhu-eng 572d538
revert gpu and dla info extraction from state
anandhu-eng 7605329
[Automated Commit] Format Codebase [skip ci]
github-actions[bot] f41b152
Update meta.yaml
anandhu-eng d500b5f
Merge branch 'dev' into dev
arjunsuresh 0b0c1fd
Merge branch 'dev' into dev
arjunsuresh 15ddcd6
Merge branch 'dev' into dev
arjunsuresh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard this for v5.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in commit 796c363.
For 5.0, the correct format is
--dla/gpu_batch_size=model:batch_size
. Since users could provide batch size manually, I have placedMLC_MLPERF_NVIDIA_HARNESS_GPU_BATCH_SIZE
as alternative source to state.