-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --output-file option to run-csv-items #881
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One suggestion.
Hi Barbra, thank you so much for tagging me for the review! The changes look great and thank you for your help ;) One nit I have is if we are going to have more than 1 output file in the future. That way, a directory might be a better choice? However, there is no need to concern about that right now |
As requested by the evaluator workstream, users can optionally specify the target file location via
--output-file
when runningrun-csv-items
.