Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --output-file option to run-csv-items #881

Closed
wants to merge 4 commits into from

Conversation

bkorycki
Copy link
Contributor

@bkorycki bkorycki commented Feb 25, 2025

As requested by the evaluator workstream, users can optionally specify the target file location via --output-file when running run-csv-items.

@bkorycki bkorycki requested review from wpietri and tsunamit February 25, 2025 23:50
@bkorycki bkorycki requested a review from a team as a code owner February 25, 2025 23:50
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 25, 2025 23:50 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 25, 2025 23:50 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 25, 2025 23:50 — with GitHub Actions Inactive
Copy link

github-actions bot commented Feb 25, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion.

@bkorycki bkorycki temporarily deployed to Scheduled Testing February 26, 2025 16:39 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 26, 2025 16:39 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 26, 2025 16:39 — with GitHub Actions Inactive
@bkorycki bkorycki changed the title Add --output-path option to run-csv-items Add --output-file option to run-csv-items Feb 26, 2025
@BBBlair
Copy link

BBBlair commented Mar 9, 2025

Hi Barbra, thank you so much for tagging me for the review! The changes look great and thank you for your help ;)

One nit I have is if we are going to have more than 1 output file in the future. That way, a directory might be a better choice? However, there is no need to concern about that right now

@bkorycki
Copy link
Contributor Author

@BBBlair Yes that makes sense! I opened a new PR here

@bkorycki bkorycki closed this Mar 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants