feat: replace light/dark portraits with single unified image#841
Merged
feat: replace light/dark portraits with single unified image#841
Conversation
Simplify the portrait system from three theme-specific images to one. Remove CSS light/dark toggle logic and add subtle brightness filter for dark mode to soften the white background. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dosubot
bot
added
the
size:M
Deploying mldangelo with
|
| Latest commit: |
15f6f58
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab54caa5.mldangelo.pages.dev |
| Branch Preview URL: | https://feat-simplify-portrait.mldangelo.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the site’s portrait/avatar handling by moving from theme-specific images (light/dark) to a single shared portrait asset, while keeping dark-mode aesthetics via a CSS brightness adjustment.
Changes:
- Simplifies
ThemePortraitfrom a two-image theme swap to a single<img>pointing at/images/me.jpg. - Removes the light/dark portrait CSS toggling rules and adds dark-mode
filter: brightness(0.85)for hero and footer avatars. - Replaces/removes portrait image assets to rely on a single portrait file.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/Template/ThemePortrait.tsx | Switches to a single portrait image render path. |
| public/images/me.jpg | Adds the unified portrait asset used across UI and metadata. |
| public/images/me-light.jpg | Removed legacy light-mode portrait asset. |
| public/images/me-dark.jpg | Removed legacy dark-mode portrait asset. |
| app/styles/pages/home.css | Applies a dark-mode brightness filter to the hero avatar image. |
| app/styles/dark-mode.css | Applies a dark-mode brightness filter to the footer avatar image; removes theme-swap rules. |
| app/styles/components/cards.css | Removes theme-specific portrait visibility rules, leaving base portrait wrapper styling. |
Comments suppressed due to low confidence (1)
src/components/Template/ThemePortrait.tsx:19
ThemePortraitis no longer theme-aware (it always renders/images/me.jpg), so the component/file name is now misleading. Consider renaming it to something likePortrait/AvatarPortrait(and updating imports) to better reflect its behavior and avoid confusion for future contributors.
export default function ThemePortrait({
width,
height,
priority = false,
className = '',
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/styles/pages/home.css
Outdated
Comment on lines
+379
to
+381
| [data-theme='dark'] .hero-avatar img { | ||
| filter: brightness(0.85); | ||
| } |
Eliminates visible white background corners in dark mode and gives a more modern look for the headshot. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move duplicated brightness filter from hero-specific and footer-specific rules to a single .theme-portrait img selector in dark-mode.css. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
me-light.jpg,me-dark.jpg,me.jpg) with a single new portraitThemePortraitcomponent from dual-image CSS toggle to a single<img>tagcards.cssanddark-mode.cssfilter: brightness(0.85)for dark mode to soften the white background on both hero and footer avatarsTest plan
🤖 Generated with Claude Code