Accept ALREADY_EXISTS error code alongside RESOURCE_ALREADY_EXISTS#242
Open
daniellok-db wants to merge 1 commit into
Open
Accept ALREADY_EXISTS error code alongside RESOURCE_ALREADY_EXISTS#242daniellok-db wants to merge 1 commit into
daniellok-db wants to merge 1 commit into
Conversation
Some MLflow / Databricks backends raise ALREADY_EXISTS where the code previously expected only RESOURCE_ALREADY_EXISTS, causing benign "resource exists" branches to bubble up as errors. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALREADY_EXISTSwhere the existing code expected onlyRESOURCE_ALREADY_EXISTS, causing benign "resource already exists" branches to bubble up as errors.error_codechecks (common/model_utils.py,common/mlflow_utils.py, two incopy/copy_utils.py) to accept either code.prompt/import_prompt.py,evaluation_dataset/import_evaluation_dataset.py) to match"ALREADY_EXISTS", which subsumes the longer literal.Test plan
RESOURCE_ALREADY_EXISTSto confirm no regression.ALREADY_EXISTSto confirm the "already exists" branch is taken instead of raising.This pull request and its description were written by Isaac.