Conversation
|
I published a new version of tblgen v0.5.0 |
This reverts commit 53668df.
macro/src/dialect.rs
Outdated
| parser = parser.add_source( | ||
| &input | ||
| .files() | ||
| .map(|path| format!(r#"include "{path}""#)) |
There was a problem hiding this comment.
I noticed that the llvm::SourceMgr class doens't actually handle "multiple files" but there is only one main file and other complementary files in there. So we didn't have to fix the TableGenParser::add_source_file. method...
For now, we fall back to the original approach of defining the main file on the fly with a bunch of include statements.
There was a problem hiding this comment.
Actually, now I wonder if we should expose the add_source and add_source_file methods of TableGenParser in the current way because it's confusing and only the first call of the method makes sense in most cases.
macro/Cargo.toml
Outdated
| tblgen = { version = "0.4.0", features = [ | ||
| tblgen = { version = "0.5.0", features = [ | ||
| "llvm19-0", | ||
| ], default-features = false, package = "tblgen-alt" } |
There was a problem hiding this comment.
We got permission to publish to the original tblgen crate, i published 0.5.2 there, if you can remove the "package =..." to use it. Thanks!
2 participants
This PR refactors dialect macro input.
References
AddIncludeFilemethod tblgen-rs#18