Closed
Conversation
Add lifetimes (mostly `'_`) in many places to resolve many instances of
the following warning:
hiding a lifetime that's elided elsewhere is confusing
Of course this warning is harmless, but I hope reducing warning noise
can help in spotting more important warnings.
Member
|
Hi. Thank you for your changes! We instead merged #723 because the other parts of the CI was broken as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lifetimes (mostly
'_) in many places to resolve many instances of the following warning:Of course this warning is harmless, but I hope reducing warning noise can help in spotting more important warnings.
Testing
It still compiles, and
cargo teststill passes