Implement Hash for attributes and types#778
Merged
raviqqe merged 2 commits intomlir-rs:mainfrom Jan 1, 2026
Merged
Conversation
0xddom
force-pushed
the
hash-attrs-types
branch
2 times, most recently
from
758420a to
5e08fc9
Compare
0xddom
force-pushed
the
hash-attrs-types
branch
from
26a2b33 to
ce43215
Compare
Member
|
Thanks for the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds implementations for
std::hash::HashforAttribute,Typeand their corresponding subtypes. Since attributes and types are uniquely stored in the MLIR context it should be enough to hash the pointer to them.Edit: For some reason, commits from a previous PR I did (#753) popped up here. Fixing it.