fixes lifetime issue in OperationResult::owner()#784
Merged
raviqqe merged 2 commits intomlir-rs:mainfrom Jan 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a lifetime issue in the OperationResult::owner() method by properly preserving the 'a lifetime parameter that represents the parent operation's lifetime. Previously, the lifetime was being erased with '_, which lost important lifetime information.
Key Changes
- Updated the impl block to preserve the
'alifetime parameter instead of using'_ - Changed the return type of
owner()to properly reflect the parent operation's lifetime - Rewrote the test to validate
OperationResult::owner()behavior instead of usingBlockArgument
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raviqqe
reviewed
Jan 7, 2026
|
|
||
| /// Returns an owner operation. | ||
| pub fn owner(&self) -> OperationRef<'c, '_> { | ||
| pub fn owner(&self) -> OperationRef<'c, 'a> { |
Member
|
Thank you for the changes! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifetime of the return value of
OperationResult::owner()was incorrectly tied to the lifetime of&selfdue to not being explicitly specified. Additionally, the test case for this function did not reveal the error because it was callingBlockArgument::owner()instead!