fix: resolve TypeError during leaderboard sort on AutoML reload (fixes #681)#833
Open
manoprasad2006 wants to merge 1 commit into
Open
fix: resolve TypeError during leaderboard sort on AutoML reload (fixes #681)#833manoprasad2006 wants to merge 1 commit into
manoprasad2006 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #681 — AutoML reload crashes with
TypeError: '<' not supported between instances of 'float' and 'str'during model stacking orleaderboard sorting.
Root Cause
ModelFramework.save()serializedfinal_losstoframework.jsonas a string via
str(desc["final_loss"]).ModelFramework.load()read it back as a raw string (e.g."0.1234").mixed
float(new models) andstr(reloaded models) inmetric_value.ldb.sort_values(by="metric_value")crashed because Python 3 does notsupport
<comparisons betweenfloatandstr.Changes
supervised/model_framework.pystr()cast fromfinal_lossinModelFramework.save()so it is written as a numeric float
float()conversion inModelFramework.load()with atry-except for backward compatibility with older saved directories
supervised/ensemble.pyfloat()conversion inEnsemble.load()when readingbest_lossfromensemble.jsonfor extra robustnessTesting
Verified by reloading a saved AutoML directory and continuing training —
leaderboard sorts correctly with no TypeError.
Closes #681