Only change input resolution if loading model weights #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates model configuration to support dynamic input resolution changes based on the loaded weights. Key changes include:
- Adding an "input_resolution" key to each model configuration dictionary.
- Updating fix_resolution calls in DenseNet’s features2 and forward methods, as well as ResNet’s forward method, to use the provided input resolution when available.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a conditional resolution update that only applies when model weights are loaded, allowing the input resolution to be dynamically set from the model configuration.
- Added "input_resolution" entries in model_urls for various weight configurations.
- Replaced hardcoded resolution values with conditional checks using the input_resolution attribute in multiple model functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.