Skip to content

feat(predict-type): Add option for changing default predict type #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 14, 2025
Merged

feat(predict-type): Add option for changing default predict type #1280

merged 7 commits into from
Apr 14, 2025

Conversation

sebffischer
Copy link
Member

@sebffischer sebffischer commented Apr 9, 2025 •
edited
Loading

Summary

  • Add a warning when different predict types are specified in learners passed to benchmark_grid().
  • Add option to select "prob" as the default predict type for classification learners (if available).

@sebffischer
feat(predict-type): Add option for changing default predict type
3871c23 
We also added a warning when mixing predict types in a
`benchmark()` call. This can be disabled.

Resolves Issue #1273
@sebffischer
document field
034c334
@sebffischer
...
ddfd945
@sebffischer sebffischer marked this pull request as draft April 10, 2025 14:43
@sebffischer
Copy link
Member Author

sebffischer commented Apr 10, 2025 •
edited
Loading

TODOs:

@sebffischer sebffischer marked this pull request as ready for review April 14, 2025 06:05
@sebffischer sebffischer merged commit fd6b3ea into main Apr 14, 2025
3 checks passed
@sebffischer sebffischer deleted the bmr-predict-type branch April 14, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebffischer