Skip to content

Adding learner from package sparsediscrim #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AnnaNzrv
Copy link
Collaborator

@AnnaNzrv AnnaNzrv commented May 21, 2025

Adding three new classification learners from the package sparsediscrim, that are also used by tidymodels for linear discriminant analysis:

  • Diagonal Linear Discriminant Analysis classif learner (dlda)
  • Minimum Distance Empirical Bayesian classif learner (mdeb)
  • Shrinkage-based Diagonal Linear Discriminant Analysis classif learner (sdlda)

Thank you for contributing a learner to the mlr3 ecosystem.
Please make sure that:

  • [X ] The added learner(s) are sufficiently tested
  • [X ] All the CI tests are passing (including the CodeFactor)
  • [X ] You ran devtools::document()
  • You updated the NEWS.md field to include the addition of the learner
  • [X ] You did not modify anything not related to the new learner
  • [X ] You are listed as a contributor in the DESCRIPTION of the R package

@AnnaNzrv AnnaNzrv marked this pull request as ready for review May 21, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant