feat/callback-lr_schedule by cxzhang4 · Pull Request #317 · mlr-org/mlr3torch

cxzhang4 · 2025-01-03T12:22:57Z

No description provided.

… are either something or list

R/CallbackSetLRScheduler.R

pass named additional arg, if code was working before it was probably by accident Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>

…interface that doesn't use it

…m ps is not inferred

R/CallbackSetLRScheduler.R

Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>

tests/testthat/test_CallbackSetLRScheduler.R

R/CallbackSetLRScheduler.R

R/TorchDescriptor.R

tests/testthat/test_CallbackSetLRScheduler.R

R/CallbackSetLRScheduler.R

cxzhang4 added 18 commits December 6, 2024 09:16

started docs for callback

574da40

Merge branch 'main' into feat/callback-lr_schedule

b2ec70c

ough outline

795c0ba

add test file

36fa621

pre-christmas work from laptop

f03a741

very simple change

6664ec4

idrk

e25c623

fewioj

58ff44a

typed out all pre-implemented schedulers. TODO: implement params that…

f4d46ee

… are either something or list

a comment

31aa858

check class fn

1ff1e88

awejoifeawjoi

3702ff6

comment

b5913c1

trains for cosine annealing, still need to test

43994d3

modified check_class_or_list to not accept vectors

3899452

some tests from Claude, not run yet

71ad99f

LLM tests fail

78f0b8b

sketch tests, incomplete

5d96fab

sebffischer reviewed Jan 3, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

sebffischer reviewed Jan 3, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Show resolved Hide resolved

cxzhang4 and others added 10 commits January 7, 2025 07:47

Update R/CallbackSetLRScheduler.R

0f21732

pass named additional arg, if code was working before it was probably by accident Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>

named additional arg for all torch-provided schedulers

539b36d

playing around with stuff

34f0845

weoiweoij

a94963d

accept incoming

d808346

tests look ok, still need to debug implementation and document

e1cac87

ewfojiewfoij

4d677b8

idk how to have a named arg for the scheduler_fn and also support an …

ac1af70

…interface that doesn't use it

stuff

731b0c6

tests still don't work, .scheduler seems to be expected and the custo…

c9432db

…m ps is not inferred

cxzhang4 commented Jan 10, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Show resolved Hide resolved

cxzhang4 commented Jan 10, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

cxzhang4 commented Jan 10, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

cxzhang4 commented Jan 10, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

cxzhang4 commented Jan 10, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

cxzhang4 commented Jan 10, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Show resolved Hide resolved

cxzhang4 added 9 commits January 10, 2025 09:31

began pr issues

216c937

Merge branch 'main' into feat/callback-lr_schedule

d548ef7

more revisions from PR

a6b8467

tests passing

826f984

delete attic file

d7a834d

allow custom id

d311c85

chatgpt says the large paramsets look ok

327ada3

Merge branch 'main' into feat/callback-lr_schedule

c222202

test passes but does not allow setting the parameter later

668fa6b

sebffischer reviewed Jan 11, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

cxzhang4 and others added 2 commits January 11, 2025 13:17

Update R/CallbackSetLRScheduler.R

5542c73

Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>

comment on test:

7b34465

cxzhang4 commented Jan 11, 2025

View reviewed changes

tests/testthat/test_CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

removed unnecessary test

254b8cc

sebffischer reviewed Jan 14, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

sebffischer reviewed Jan 14, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

sebffischer requested changes Jan 14, 2025

View reviewed changes

address comments from (hopefully final) review

58a20d4

sebffischer reviewed Jan 15, 2025

View reviewed changes

R/CallbackSetLRScheduler.R Outdated Show resolved Hide resolved

Update R/CallbackSetLRScheduler.R

53c4002

sebffischer approved these changes Jan 15, 2025

View reviewed changes

docs(news): update changelog

6d375ca

sebffischer merged commit bb1bcac into main Jan 16, 2025
6 checks passed

sebffischer deleted the feat/callback-lr_schedule branch January 16, 2025 18:41

Uh oh!

Comments

Conversation

cxzhang4 commented Jan 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants