Skip to content

Commit

Permalink
fix internal search space for at (#462)
Browse files Browse the repository at this point in the history
  • Loading branch information
sebffischer authored Oct 31, 2024
1 parent 61802ed commit 8c4a4a2
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 1 deletion.
2 changes: 1 addition & 1 deletion R/AutoTuner.R
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ AutoTuner = R6Class("AutoTuner",
ia$resampling = assert_resampling(resampling)$clone()
if (!is.null(measure)) ia$measure = assert_measure(as_measure(measure), learner = learner)
if (!is.null(search_space)) ia$search_space = assert_param_set(as_search_space(search_space))$clone()
if (!is.null(internal_search_space)) ia$search_space = assert_param_set(as_search_space(internal_search_space))$clone()
if (!is.null(internal_search_space)) ia$internal_search_space = assert_param_set(as_search_space(internal_search_space))$clone()
ia$terminator = assert_terminator(terminator)$clone()

ia$store_models = assert_flag(store_models)
Expand Down
37 changes: 37 additions & 0 deletions tests/testthat/test_AutoTuner.R
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,43 @@ test_that("AutoTuner works with internal tuning and validation", {
expect_true(is.null(at$model$learner$state$internal_valid_task_ids))
})

test_that("AutoTuner works when internal_search_space is passed separately", {
task = tsk("iris")
search_space = ps(x = p_dbl(0.2, 0.3))
internal_search_space = ps(iter = p_int(upper = 1000L, aggr = function(x) length(x)))
at = auto_tuner(
tuner = tnr("random_search", batch_size = 2),
learner = lrn("classif.debug", early_stopping = TRUE, validate = "test"),
resampling = rsmp("cv", folds = 3),
search_space = search_space,
internal_search_space = internal_search_space,
measure = msr("classif.ce"),
term_evals = 4
)
at$train(task)
expect_equal(at$model$learner$param_set$values$iter, 3)
expect_false(at$model$learner$param_set$values$early_stopping)
})

test_that("AutoTuner works when internal_search_space is part of primary search space", {
task = tsk("iris")
search_space = ps(
x = p_dbl(0.2, 0.3),
iter = p_int(upper = 1000L, aggr = function(x) length(x), tags = "internal_tuning")
)
at = auto_tuner(
tuner = tnr("random_search", batch_size = 2),
learner = lrn("classif.debug", early_stopping = TRUE, validate = "test"),
resampling = rsmp("cv", folds = 3),
search_space = search_space,
measure = msr("classif.ce"),
term_evals = 4
)
at$train(task)
expect_equal(at$model$learner$param_set$values$iter, 3)
expect_false(at$model$learner$param_set$values$early_stopping)
})

test_that("AutoTuner works with set_validate function", {
at = auto_tuner(
tuner = tnr("random_search", batch_size = 2),
Expand Down

0 comments on commit 8c4a4a2

Please sign in to comment.