Directly test version in skip_if_not_installed() (#469)

* Directly test version in skip_if_not_installed() * one more in test_Tuner.R
mlr-org · Nov 22, 2024 · b21a0ad · b21a0ad
1 parent 4b6c958
commit b21a0ad
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/tests/testthat/test_AutoTuner.R b/tests/testthat/test_AutoTuner.R
@@ -133,8 +133,7 @@ test_that("AutoTuner works with graphlearner", {
 })
 
 test_that("Nested resampling works with graphlearner", {
-  skip_if_not_installed("mlr3pipelines")
-  skip_if(packageVersion("mlr3pipelines") < "0.5.3")
+  skip_if_not_installed("mlr3pipelines", "0.5.3")
   requireNamespace("mlr3pipelines")
 
   gl = MAKE_GL()
@@ -275,8 +274,7 @@ test_that("search space from TuneToken works", {
 })
 
 test_that("AutoTuner get_base_learner method works", {
-  skip_if_not_installed("mlr3pipelines")
-  skip_if(packageVersion("mlr3pipelines") < "0.5.3")
+  skip_if_not_installed("mlr3pipelines", "0.5.3")
   requireNamespace("mlr3pipelines")
 
   # simple learner

diff --git a/tests/testthat/test_Tuner.R b/tests/testthat/test_Tuner.R
@@ -267,8 +267,7 @@ test_that("proper error when primary search space is empty", {
 })
 
 test_that("internal tuning: branching", {
-  skip_if_not_installed("mlr3pipelines")
-  skip_if(packageVersion("mlr3pipelines") < "0.5.3")
+  skip_if_not_installed("mlr3pipelines", "0.5.3")
   # this case is special, because not all internally tuned parameters are present in every iteration, only those that
   # are in the active branch are
   glrn = mlr3pipelines::ppl("branch", graphs = list(