Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(at): unused AB and check on required params #472

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix(at): unused AB and check on required params #472

merged 2 commits into from
Nov 26, 2024

Conversation

sebffischer
Copy link
Member

  1. internal_valid_scores is some unremoved leftover
  2. When calling $get_values() in the $initialize() method of the AutoTuner this can fail when required parameters are part of the search space but not set in the learner.

@sebffischer sebffischer marked this pull request as draft November 25, 2024 14:42
@sebffischer sebffischer changed the title fixes fix(at): unused AB and check on required params Nov 26, 2024
@sebffischer sebffischer marked this pull request as ready for review November 26, 2024 09:56
@be-marc be-marc merged commit 87f4f41 into main Nov 26, 2024
4 of 5 checks passed
@be-marc be-marc deleted the fix-at-1 branch November 26, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebffischer @be-marc