[Module] vLLM module update#950
Closed
guylei-code wants to merge 18 commits intomlrun:developmentfrom
Closed
Conversation
Correct the format of the generationDate field.
Added copyright information and module description.
Co-authored-by: Eyal Danieli <eyal_danieli@mckinsey.com>
Co-authored-by: Eyal Danieli <eyal_danieli@mckinsey.com>
Updated the description to provide more details about the vLLM module's functionality and configuration options.
Added docstring to VLLMModule class to describe its purpose and functionality.
# Conflicts: # modules/src/vllm_module/test_vllm_module.py # modules/src/vllm_module/vllm_module.py
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
guylei-code
requested review from
Eyal-Danieli,
GiladShapira94 and
danielperezz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the notebook and fixed the issue with the incompatible output