Fix committer lag of one record when NoSqlTarget is used#548
Merged
gtopper merged 1 commit intomlrun:developmentfrom Dec 15, 2024
Merged
Fix committer lag of one record when NoSqlTarget is used#548gtopper merged 1 commit intomlrun:developmentfrom
NoSqlTarget is used#548gtopper merged 1 commit intomlrun:developmentfrom
Conversation
`NoSqlTarget` must not keep a reference to the last event it processed, or else the GC can't collect it, and its offset won't be committed. [ML-4421](https://iguazio.atlassian.net/browse/ML-4421)
assaf758
approved these changes
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoSqlTargetmust not keep a reference to the last event it processed, or else the GC can't collect it, and its offset won't be committed.ML-4421