Skip to content

Add overridable is_streaming() to ParallelExecutionRunnable#611

Merged
gtopper merged 1 commit intomlrun:developmentfrom
gtopper:ML-11878-2
Feb 1, 2026
Merged

Add overridable is_streaming() to ParallelExecutionRunnable#611
gtopper merged 1 commit intomlrun:developmentfrom
gtopper:ML-11878-2

Conversation

@gtopper
Copy link
Collaborator

@gtopper gtopper commented Feb 1, 2026

Adds an is_streaming() method to ParallelExecutionRunnable that detects whether the runnable produces streaming output by inspecting run() and run_async() for generator functions.

Subclasses can override this method when streaming detection requires custom logic (e.g., when the runnable delegates to other methods like predict() in mlrun).

To enable a cleaner solution to ML-11878.

Adds an `is_streaming()` method to `ParallelExecutionRunnable` that detects whether the runnable produces streaming output by inspecting `run()` and `run_async()` for generator functions.
>
> Subclasses can override this method when streaming detection requires custom logic (e.g., when the runnable delegates to other methods like `predict()` in mlrun).

To enable a cleaner solution to [ML-11878](https://iguazio.atlassian.net/browse/ML-11878).
@gtopper gtopper requested a review from royischoss February 1, 2026 12:00
Copy link
Collaborator

@royischoss royischoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtopper gtopper merged commit af69b05 into mlrun:development Feb 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants