Batch step error handling#612
Merged
davesh0812 merged 11 commits intomlrun:developmentfrom Feb 9, 2026
Merged
Conversation
royischoss
reviewed
Feb 9, 2026
Collaborator
royischoss
left a comment
royischoss
left a comment
There was a problem hiding this comment.
Hey looks good, small comment
storey/flow.py
Outdated
| for result in results: | ||
| if isinstance(result.data, list): | ||
| sub_event_body[result.runnable_name] = result.data[i] | ||
| else: |
Collaborator
There was a problem hiding this comment.
why here the case is different and not checking for error and dict? or the comment is not accurate, as discussed use the check above and add else with error raising, plus adding test to check it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support error duplication for sub-events in batched events.
ML-12068