Update extendr-api to 0.9.0#28
Merged
Merged
Conversation
Breaking changes in extendr 0.9.0: - Result removed from prelude (qualify as extendr_api::Result) - Nullable<T> now requires T: TryFrom<&Robj> (add ref impls for custom types: RVocab, RMerges, RUnigramVocab, RPaddingParams, RTruncationParams) Also updates rextendr version to 0.5.0, README badge, NEWS, and re-vendors dependencies.
On macOS, R's Makeconf defines MACOSX_DEPLOYMENT_TARGET but make doesn't export it to recipe subprocesses. This causes the cc crate (used by onig_sys) to fall back to SDK version detection, producing linker warnings about mismatched deployment targets. Conditionally export the variable in the cargo build recipe so the cc crate uses the correct target.
The cc crate (used by onig_sys) falls back to the SDK version when MACOSX_DEPLOYMENT_TARGET is unset. This can be newer than what R's clang defaults to, causing linker warnings about mismatched targets. At configure time, detect R's deployment target by: 1. Checking the MACOSX_DEPLOYMENT_TARGET env var 2. Parsing -mmacosx-version-min from R CMD config CC/CFLAGS 3. Querying clang's __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ macro Then inject it into Makevars so cargo and the cc crate use the same deployment target as R.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extendr-apifrom 0.8.1 to 0.9.0 andrextendrconfig from 0.4.2 to 0.5.0Resultin trainers.rs, addTryFrom<&Robj>impls for custom types used withNullable<T>Test plan
cargo buildcompiles cleanlyR CMD INSTALLsucceedsdevtools::test()